Review of "Tiling Shell" version 17.3 (70)

Details Page Preview

Extend Gnome Shell with advanced tiling window management. Supports multiple monitors, Windows 11 Snap Assistant, Fancy Zones, automatic tiling, keyboard shortcuts, customised tiling layouts and more!

Extension Homepage
https://github.com/domferr/tilingshell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
17.3 (70) Rejected
17.3 (69) Active
17.3 (68) Inactive
17.2 (67) Active
17.2 (66) Active
17.2 (65) Rejected
17.2 (64) Rejected
17.2 (63) Rejected
17.1 (62) Active
17.1 (61) Active
17.1 (60) Rejected
17.0 (59) Active
17.0 (58) Active
17.0 (57) Inactive
17.0 (56) Rejected
16.4 (55) Active
16.4 (54) Active
16.4 (53) Rejected
16.3 (52) Inactive
16.3 (51) Active
16.2 (50) Active
16.2 (49) Active
16.1 (48) Active
16.1 (47) Active
16.0 (46) Inactive
16.0 (45) Inactive
16.0 (44) Inactive
15.1 (43) Active
15.1 (42) Active
15.1 (41) Rejected
15.0 (40) Active
15.0 (39) Active
15.0 (38) Rejected
14.1 (37) Active
14.1 (36) Active
14.1 (35) Rejected
14 (34) Active
14 (33) Active
14 (32) Inactive
14 (31) Rejected
13.1 (30) Active
13.1 (29) Active
13.0 (28) Active
13.0 (27) Active
12.2 (26) Active
12.2 (25) Active
12.1 (24) Active
12.1 (23) Active
12 (22) Active
12 (21) Active
12 (20) Inactive
12 (19) Inactive
11.1 (18) Active
11.1 (17) Active
11 (16) Active
11 (15) Active
11 (14) Rejected
10.0 (13) Active
10.0 (12) Active
9.1 (11) Active
9.1 (10) Active
9.0 (9) Active
9.0 (8) Active
8.0 (7) Active
8.0 (6) Active
5 Active
4 Active
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Is this a bad upload? Because if the icons are in gresources, they shouldn't be shipped in the package in `icons` folder.
domferr posted a review
Hi thanks for reviewing. Where the icons should be? I'm not familiar with this
JustPerfection posted a review
Hi, aren't they compiled in the `resources.gresource`?
domferr posted a review
Yes, this is the raw one ``` <?xml version="1.0" encoding="UTF-8"?> <gresources> <gresource prefix="/org/gnome/Shell/Extensions/tilingshell"> <file preprocess="xml-stripblanks">icons/scalable/actions/edge-adaptive-symbolic.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/edge-adaptive-symbolic-dark.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/edge-default-symbolic.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/edge-default-symbolic-dark.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/edge-granular-symbolic.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/edge-granular-symbolic-dark.svg</file> </gresource> </gresources> ``` And the icons are placed in those folders.
JustPerfection rejected
If they are in the compiled resource, they shouldn't be in the package.
domferr posted a review
Sorry but I didn't understand. Where should they go? To summarise, I have created those icons and they will be used in the extension's preferences. So my understanding is that those icons must be shipped together with the extension. What am I missing? Thank you!
JustPerfection posted a review
Remove `icons` folder for the package you are sending here. No need to include them in the package since you already have them in `resources.gresource`. For example, look at my own extension: This is the resource I'm using: https://gitlab.gnome.org/jrahmatzadeh/just-perfection/-/tree/main/src/data but when it comes to the package I'm posting to EGO, it only has `resources.gresource` in the package not the `data` folder: https://extensions.gnome.org/review/68110