GNOME Shell Extensions

Review of "User Theme X" version 44

Details Page Preview

User Theme X

by grroot

Switch day/night user theme&stylesheet when the enabled Night Light gets inactive/active For support, please report issues in time via the Homepage link below rather than the review section below it

Extension Homepage
https://github.com/tuberry/user-theme-x
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO029 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • fubar.js:120 
    x.run_dispose()

EGO036 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • fubar.js:25 
    Extension.lookupByURL(import.meta.url)

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • prefs.js:72 
            this[$]
            .set(strv.length > 9 ? {
                enableSearch: true, searchMatchMode: Gtk.StringFilterMatchMode.SUBSTRING,
                expression: new Gtk.PropertyExpression(Gtk.StringObject, null, 'string'),
            } : null)[$]
            .set_model(Gtk.StringList.new(

All Versions