Review of "User Theme X" version 44

Details Page Preview

Switch day/night user theme&stylesheet when the enabled Night Light gets inactive/active For support, please report issues in time via the Homepage link below rather than the review section below it

Extension Homepage
https://github.com/tuberry/user-theme-x

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • fubar.js:120
    x.run_dispose()

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • fubar.js:25
    Extension.lookupByURL(import.meta.url)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • fubar.js:33
    St.Clipboard.get_default()
  • fubar.js:34
    St.Clipboard.get_default()

All Versions

Previous Reviews on this Version

grroot posted a review
> EGO029 `run_dispose` This follows the GNOME Shell practice [0] thus is considered ‘absolutely necessary’ and has been commented in accordance with the guideline [1]. [0] https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/a540670a9f468298fb7ccce6f2544cd4180a4db1/js/ui/keyboard.js#L1996-L1998 [1] https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject > EGO036 `lookupByURL` It's a misjudgment. Conversely, the guidelines recommend using them `if subclassing Extension and ExtensionPreferences` [2]. [2] https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils > EGO-A-005 clipboard These are shared library functions that this extension may not use, but all clipboard-related operations are either disabled by default and must be enabled manually, or require manual user intervention as the guideline required.
JustPerfection active