GNOME Shell Extensions

Review of "User Theme X" version 44

Details Page Preview

User Theme X

by grroot

Switch day/night user theme&stylesheet when the enabled Night Light gets inactive/active For support, please report issues in time via the Homepage link below rather than the review section below it

Extension Homepage
https://github.com/tuberry/user-theme-x
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • fubar.js:120 
    x.run_dispose()

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • fubar.js:25 
    Extension.lookupByURL(import.meta.url)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • fubar.js:33 
    St.Clipboard.get_default()
  • fubar.js:34 
    St.Clipboard.get_default()

All Versions