Review of "ArcMenu" version 69.2 (73)

Details Page Preview

Application menu for GNOME Shell Features include: various menu layouts, built in GNOME search, quick access to system shortcuts, and much more! Requires GMenu package: - Debian / Ubuntu: libgnome-menu-3-0, gir1.2-gmenu-3.0 - Fedora: gnome-menus - Arch / Manjaro: gnome-menus - openSUSE: libgnome-menu-3-0, typelib-1_0-GMenu-3_0 General Help: - Visit https://gitlab.com/arcmenu/ArcMenu/-/wikis/home Please report all bugs or issues at https://gitlab.com/arcmenu/ArcMenu

Extension Homepage
https://gitlab.com/arcmenu/ArcMenu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 3 warning 2 manual_review 1

Shexli found 6 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • menuButton.js:168
    Extension.lookupByUUID(Constants.DASH_TO_PANEL_UUID)
  • utils.js:489
    Extension.lookupByUUID(uuid)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • menuWidgets.js:2598
    St.Clipboard.get_default()
  • search.js:139
    St.Clipboard.get_default()

EGO-C49-002 error

extensions targeting GNOME 49 must not use removed Clutter action classes

This extension explicitly targets GNOME Shell 49 but still uses removed `Clutter.ClickAction` or `Clutter.TapAction`.

Clutter.ClickAction() and Clutter.TapAction()

  • utils.js:674
    new Clutter.ClickAction(actionParams)

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.arcmenu.gschema.xml
    id='org.gnome.shell.extensions.arcmenu.pinned-apps-folders' path=''

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.arcmenu.gschema.xml
    id='org.gnome.shell.extensions.arcmenu.pinned-apps-folders' path=''

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • menulayouts/pop.js:796
                this._folder = new Gio.Settings({
                    schema_id: 'org.gnome.desktop.app-folders.folder',
                    path,
                })

All Versions

Version Status
69.2 (73) Active
69.1 (72) Inactive
69.0 (71) Active
68.0 (70) Active
67.2 (69) Active
67.1 (68) Active
67.0 (67) Active
66 (66) Active
65 (65) Active
64 (64) Active
63 (63) Active
62 (62) Active
61 (61) Active
60 (60) Active
59 (59) Active
58 (58) Active
57 (57) Active
56 (56) Active
55 (55) Active
54 (54) Active
53 (53) Active
52 Active
51 Active
50 Rejected
49 Active
48 Active
47 Active
46 Active
45 Active
44 Active
43 Active
42 Active
41 Active
40 Rejected
39 Active
38 Active
37 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Rejected
16 Active
13 Active
10 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection active