Review of "Forge" version 1

Details Page Preview

Tiling and window manager for GNOME - Please report bugs/issues on https://github.com/forge-ext/forge/issues - Needs a new maintainer.

Extension Homepage
https://github.com/forge-ext/forge

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Move line 43, 44 to enable (extension.js). You cannot create objects in init: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization 2. If you are not using these files "yet", you need to remove it for your package. You are just importing without using anything there: command.js workspace.js widgets.js https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Don.27t_include_unecessary_files 3. You don't need to create your custom settings function. Use this instead: this.kbdSettings = ExtensionUtils.getSettings(); also add this to metadata.json: "settings-schema": "org.gnome.shell.extensions.forge.keybindings", 4. Also remove these files: icons/.gitkeep settings.js (not needed after using ExtensionUtils) 5. On disable you also need to do this: this.forgeWm = null; this.keybindings = null; 6. You can open prefs without spawn command line. Use this instead: ExtensionUtils.openPrefs(); If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions