Review of "Forge" version 74

Details Page Preview

Tiling and window manager for GNOME Please report bugs/issues on https://github.com/forge-ext/forge/issues

Extension Homepage
https://github.com/forge-ext/forge

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove the version from imports, because parent is the owner of prefs window and already specified the version: - line 20-21 prefs.js - line 4 lib/prefs/keyboard.js - line 4 lib/prefs/appearance.js - line 5-6 lib/prefs/widgets.js - line 3 lib/prefs/settings.js 2. Typo :p in - line 30 prefs.js (class name) - line 199 lib/extension/utils.js `orientaton` 3. You need to create objects on enable and null them out in disable (line 34 and 36 extension.js). Garbage collector cannot do it's job otherwise. 4. Selective disable is not allowed (line 69 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes