Review of "Top Panel Workspace Scroll" version 25

Details Page Preview

Change workspaces by scrolling over the top panel

Extension Homepage
https://github.com/gfxmonk/gnome-shell-scroll-workspaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
37 Active
36 Active
35 Rejected
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Rejected
27 Active
26 Active
25 Rejected
24 Active
23 Active
22 Active
21 Active
20 Active
19 Rejected
18 Active
17 Rejected
16 Active
15 Active
14 Rejected
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Inactive
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you cannot create objects in init() function: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization Line 27-65 should be in enable(). 2. What is the reason for using main() function in extension.js? 3. What is the reason for wrapping inside functions (line 28-65). 4. Please remove .pot file for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Don.27t_include_unecessary_files 5. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice You can use GObject instead: https://gjs.guide/guides/gjs/legacy-class-syntax.html#comparison-between-legacy-and-es6-implementations Learn more about removing Lang: https://wiki.gnome.org/Projects/GnomeShell/Extensions/MigratingShellClasses 6. Remove convenience.js file for the next version. We have those functions in ExtensionUtils: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions