GNOME Shell Extensions

Review of "Top Panel Workspace Scroll" version 35

Details Page Preview

Top Panel Workspace Scroll

by gfxmonk

Change workspaces by scrolling over the top panel

Extension Homepage
https://github.com/gfxmonk/gnome-shell-scroll-workspaces
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
39 Active
38 Active
37 Active
36 Active
35 Rejected
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Rejected
27 Active
26 Active
25 Rejected
24 Active
23 Active
22 Active
21 Active
20 Active
19 Rejected
18 Active
17 Rejected
16 Active
15 Active
14 Rejected
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Inactive
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 2. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Disconnect the signal on disable (line 149 `extension.js`): [EGO Review Guidelines: Disconnect signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 4. What's the reason for referencing what you already have as this? (line 22 `extension.js`).
gfxmonk posted a review
4. prevents me having to make sure I bind functions or use () =>, lexical scope is simpler I've done all these (though I still don't think 4 is actually a good idea) in the new version