Review of "Battery Health Charging" version 72

Details Page Preview

Set battery charging threshold / charging limit / charging mode Battery Health Charging: An extension to maximize the battery life of laptops by setting their charging threshold or modes. Compatibility (no dependencies required): - Asus - LG - Samsung - Sony/Vaio - Huawei - Toshiba/Dynabook - System76 - Lenovo (Ideapad, Legion) - Thinkpad - Panasonic - Fujitsu - Dell (recent kernel) - Chromebook (recent kernel) Compatibility with dependencies - Acer (kernel module) - MSI (older kernel requires kernel module) - Tuxedo (kernel module) - Slimbook (kernel module) - Tuxedo IntelQC71 (kernel module) - XMG IntelQC71 (kernel module) - Eluktronics IntelQC71 (kernel module) - Purism Librem (kernel module) - Gigabyte Aero/Aorus (kernel module) - Dell (older kernel requires libsmbios/Dell Command Configure) - Apple Macbook Intel-series chip (kernel module) - Apple Macbook M-series chip (custom kernel) - Razer (package razer-cli) - Framework (kernel module / package: framework_tool) - Chromebook (older kernel requires package ectool) Not all models are comaptible. Please read about the compatibility and dependencies of your device on github link below. https://maniacx.github.io/Battery-Health-Charging/

Extension Homepage
https://github.com/maniacx/Battery-Health-Charging

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
You shouldn't null out the timeout in line 289 `devices/Chromebook.js`.
maniacx posted a review
Since timeout sources are already removed, I think it is ok to null out. Note: I am using await wrapped promise function around timeout. So line 289 will only execute after timeout complete and is removed. Hmm unless I am misunderstood how promise works and resolve act like return in promise wrapper leaving return GLib.SOURCE_REMOVE; unreachable. Is that so?
JustPerfection posted a review
`this._delayReadTimeoutId = null;` should be inside the callback before `return GLib.SOURCE_REMOVE;`.