Review "Light Dict" version 87 - GNOME Shell Extensions

Review of "Light Dict" version 87

Details Page Preview

Light Dict

by grroot

Manipulate primary selections on the fly, typically used as Lightweight Dictionaries For support, please report issues in time via the Homepage link below rather than the review section below it

Extension Homepage: https://github.com/tuberry/light-dict

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

fubar.js:174
```
x.run_dispose()
```

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

fubar.js:25
```
Extension.lookupByURL(import.meta.url)
```

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

fubar.js:35
```
St.Clipboard.get_default()
```
fubar.js:36
```
St.Clipboard.get_default()
```

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

metadata.json
```
shell-version=['51']
```

All Versions

Version	Status
87	Active
86	Active
85	Active
84	Active
83	Active
82	Active
81	Active
80	Active
79	Active
78	Active
77	Active
76	Active
75	Rejected
74	Active
73	Rejected
72	Rejected
71	Active
70	Inactive
69	Inactive
68	Active
67	Active
66	Rejected
65	Active
64	Inactive
63	Inactive
62	Inactive
61	Inactive
60	Inactive
59	Inactive
58	Active
57	Inactive
56	Inactive
55	Rejected
54	Inactive
53	Inactive
52	Inactive
51	Inactive
50	Rejected
49	Inactive
48	Rejected
47	Active
46	Inactive
45	Rejected
44	Rejected
43	Rejected
42	Rejected
41	Inactive
40	Rejected
39	Inactive
38	Inactive
37	Rejected
36	Inactive
35	Rejected
34	Rejected
33	Rejected
32	Rejected
31	Inactive
30	Rejected
29	Rejected
28	Active
27	Active
26	Rejected
25	Inactive
24	Rejected
23	Inactive
22	Inactive
21	Rejected
20	Rejected
19	Rejected
18	Rejected
17	Rejected
16	Inactive
15	Rejected
14	Inactive
13	Inactive
12	Inactive
11	Inactive
10	Inactive
9	Inactive
8	Inactive
7	Inactive
6	Inactive
5	Inactive
4	Inactive
3	Inactive
2	Inactive
1	Rejected

Previous Reviews on this Version

JustPerfection rejected September 26, 2026

Please fix EGO-X-003 mentioned in shexli and send it again.

grroot posted a review September 26, 2026

EGO-X-003: Extensions SHOULD NOT call GObject.Object.run_dispose() unless absolutely necessary. If absolutely necessary, any call to this method MUST have a comment explaining the real-world situation that makes it a requirement. This follows the GNOME Shell practice [0] thus is considered ‘absolutely necessary’ and has been commented at `fubar.js` Line 174 in accordance with the guideline [1]. [0] https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/209865cf82e108a897bf6e40af96f8cbbb3775e8/js/ui/keyboard.js#L1879-L1881 [1] https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject So, how exactly do I fix it? :(

JustPerfection active September 26, 2026

Okay. Approved. Asked the devs and seems that's the only use case extensions can call `run_dispose()`.

JustPerfection posted a review September 26, 2026

Related Shexli issue: https://gitlab.gnome.org/Infrastructure/extensions-web/-/work_items/405