Review of "Hide Top Bar" version 129

Details Page Preview

Hides the top bar, except in overview. However, there is an option to show the panel whenever the mouse pointer approaches the edge of the screen. And if "intellihide" is enabled, the panel only hides when a window takes the space. - Press backspace to remove keyboard shortcut. - Log off and on again when there is an error after upgrading.

Extension Homepage
https://gitlab.gnome.org/tuxor1337/hidetopbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • desktopIconsIntegration.js:72
    Extension.lookupByURL(import.meta.url)

All Versions

Previous Reviews on this Version

tuxor1337 posted a review
I followed the GNOME extension best practices to remove some issues with the coding style. Thanks go to @JustPerfection for double-checking! I hope I haven't missed anything. If you see anything else that still looks uncool, please point me to it and I will be happy to fix it.
JustPerfection active
Approved but please remove `this._isEnabled`: https://gjs.guide/extensions/review-guidelines/best-practices.html#lifecycle-and-destruction-state Also, the timeout cleanup in complicated without any good reason. Just holding the timeout ids in an array or object is the way to go.
JustPerfection posted a review
For timeout, I mean the cleanup in `convenience.js`.