Review of "Persian Calendar" version 18

Details Page Preview

Shows Persian date in the top panel. It shows: 1. Persian calendar 2. It can show, today is a holiday or not! 3. Show notification onDayChanged! 4. Date converter between Persian, Gregorian and Lunar Hijri 5. Events: 5.1. Official solar events. 5.2. Official lunar events. 5.3. Official international events. 5.4. Traditional Persian events. 5.5. Persian personages. Please “rate” here and “star” the project on GitHub. Please open an issue on GitHub if you found something or have an idea!

Extension Homepage
https://github.com/omid/Persian-Calendar-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

omid posted a review
Should I add "run_dispose" to other files I included? (like "calendar.js") if "yes", how and where?
gcampax posted a review
Rejected, newer version. Anyway, as a general rule, you don't want your callbacks to survive disabling the extension, so anything that listens to external changes, such as GFileMonitor, GSettings, GDBusProxy, must have signals disconnected (to also destroy uncollectable GC loops). A fast way to do so is g_object_run_dispose().