Review of "Persian Calendar" version 117

Details Page Preview

Shows Persian date in the top panel. It shows: 1. Persian calendar 2. It can show, today is a holiday or not! 3. Show notification onDayChanged! 4. Date converter between Persian, Gregorian and Lunar Hijri 5. Events: 5.1. Official solar events. 5.2. Official lunar events. 5.3. Official international events. 5.4. Traditional Persian events. 5.5. Persian personages. Please “rate” here and “star” the project on GitHub. Please open an issue on GitHub if you found something or have an idea!

Extension Homepage
https://github.com/omid/Persian-Calendar-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

omid posted a review
As far as I saw, we cannot style (Or RTLized) the notification title/body. :/
JustPerfection active
I haven't tried it, but did you try the `lang` markup? https://web.mit.edu/ghudson/dev/nokrb/third/pango/docs/html/PangoMarkupFormat.html You should enable the markup for the notification btw.
omid posted a review
Thanks. Nope, it works, but partially. <b> and <i> works, but <span> doesn't. The code below, prints `<span...` as normal text, but prints "cool" in italic. So it prints something like: `<span foreground="blue" size="x-large">Blue text</span> is cool!` ``` new MessageTray.Notification({ source, title, iconName, isTransient: true, body: '<span foreground="blue" size="x-large">Blue text</span> is <i>cool</i>!', useBodyMarkup: true, }); ```
JustPerfection posted a review
Set the `text_direction` to the `Clutter.TextDirection.RTL` for the notification.
omid posted a review
Notification system just keeps <b>, <i> and <u>: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/util.js#L189 Thanks a lot. I'll try your second solution 🙏
omid posted a review
I couldn't find how I can set text_direction for the notification. I think it doesn't accept anything from outside: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/messageTray.js#L1121 And I shouldn't change the CSS, because it's global!