Review of "Persian Calendar" version 77

Details Page Preview

Shows Persian date in the top panel. It shows: 1. Persian calendar 2. It can show, today is a holiday or not! 3. Show notification onDayChanged! 4. Date converter between Persian, Gregorian and Lunar Hijri 5. Events: 5.1. Official solar events. 5.2. Official lunar events. 5.3. Official international events. 5.4. Traditional Persian events. 5.5. Persian personages. Please “rate” here and “star” the project on GitHub. Please open an issue on GitHub if you found something or have an idea!

Extension Homepage
https://github.com/omid/Persian-Calendar-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

omid auto- active
JustPerfection rejected
Hey, 1. You are creating Schema object in global scope (Events.js Line 14, extension.js Line 26) which is not allowed: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization Just an advice: To simplify that you can use dependency injection for Events. Like Events(Schema). In that case you only use one Schema. 2. Lang is deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice You can use GObject instead.
JustPerfection posted a review
Please come to GNOME Matrix channel if you have any questions: https://matrix.to/#/#extensions:gnome.org
omid posted a review
Thanks a lot. Will create a ticket regarding the mentioned changes.