Review "Persian Calendar" version 33 - GNOME Shell Extensions

Review of "Persian Calendar" version 33

Details Page Preview

Persian Calendar

by omid

Displays Persian (Iranian/Jalali) calendar in the top panel It offers: 1. Displays the Persian/Iranian/Jalali calendar 2. Holiday indicator 3. Day change notifications 4. Converts dates between the Persian, Gregorian, and Hijri (lunar) calendars 5. Event listings: 5.1. Official solar events 5.2. Official lunar events 5.3. Official international events 5.4. Traditional Persian events 5.5. Notable Persian figures Please “rate” the project here and give it a “star” on GitHub. If you encounter any issues or have suggestions, feel free to open an issue there on GitHub!

Extension Homepage: https://github.com/omid/Persian-Calendar-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
119	Active
118	Inactive
117	Inactive
116	Active
115	Active
114	Active
113	Rejected
112	Active
111	Rejected
110	Active
109	Active
108	Active
107	Active
106	Active
105	Rejected
104	Active
103	Rejected
102	Rejected
101	Active
100	Active
99	Active
98	Active
97	Active
96	Active
95	Active
94	Active
93	Rejected
92	Inactive
91	Active
90	Active
89	Active
88	Active
87	Active
86	Active
85	Active
84	Active
83	Active
82	Active
81	Inactive
80	Inactive
79	Inactive
78	Rejected
77	Rejected
76	Inactive
75	Rejected
74	Inactive
73	Active
72	Active
71	Rejected
70	Active
69	Active
68	Active
67	Active
66	Inactive
65	Active
64	Active
63	Active
62	Active
61	Rejected
60	Active
59	Inactive
58	Active
57	Inactive
56	Active
55	Active
54	Active
53	Active
52	Active
51	Active
50	Active
49	Active
48	Active
47	Rejected
46	Active
45	Active
41	Active
40	Rejected
39	Active
38	Active
37	Active
36	Active
35	Active
33	Rejected
32	Active
31	Active
30	Active
29	Active
28	Active
27	Active
26	Active
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Rejected
17	Rejected
16	Active
15	Rejected
14	Active
13	Active
12	Rejected
11	Active
10	Inactive
9	Rejected
8	Inactive
7	Active
6	Rejected
5	Inactive
4	Rejected
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

Meng Zhuo waiting for author September 24, 2014

PLEASE disconnect all the signals

omid posted a review September 24, 2014

I didn't change those parts in this version... how and whee should I do that?

Meng Zhuo waiting for author September 24, 2014

Your can check on http://blog.mecheye.net/2012/02/requirements-and-tips-for-getting-your-gnome-shell-extension-approved/ Like line 43: Schema.connect('changed::color', Lang.bind( you should assign to an variable and disconnect it in the disable( destory ) function. example(code is not standard ): let schema_change_signal = Schema.connect('changed::color', Lang.bind(..)) in disable: Schema.disconnect(schema_change_signal); ------------------------------------------- I am a new reviewer in extension site, any problem is welcome, you can contact me at #gnome-shell IRC channel.

omid posted a review September 24, 2014

Thanks a lot mengzho... please check next commit :-)

Meng Zhuo rejected September 24, 2014

Reject for newer version.