Review "Persian Calendar" version 84 - GNOME Shell Extensions

Review of "Persian Calendar" version 84

Details Page Preview

Persian Calendar

by omid

Shows Persian date in the top panel. It shows: 1. Persian calendar 2. It can show, today is a holiday or not! 3. Show notification onDayChanged! 4. Date converter between Persian, Gregorian and Lunar Hijri 5. Events: 5.1. Official solar events. 5.2. Official lunar events. 5.3. Official international events. 5.4. Traditional Persian events. 5.5. Persian personages. Please “rate” here and “star” the project on GitHub. Please open an issue on GitHub if you found something or have an idea!

Extension Homepage: https://github.com/omid/Persian-Calendar-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
115	Active
114	Active
113	Rejected
112	Active
111	Rejected
110	Active
109	Active
108	Active
107	Active
106	Active
105	Rejected
104	Active
103	Rejected
102	Rejected
101	Active
100	Active
99	Active
98	Active
97	Active
96	Active
95	Active
94	Active
93	Rejected
92	Inactive
91	Active
90	Active
89	Active
88	Active
87	Active
86	Active
85	Active
84	Active
83	Active
82	Active
81	Inactive
80	Inactive
79	Inactive
78	Rejected
77	Rejected
76	Inactive
75	Rejected
74	Inactive
73	Active
72	Active
71	Rejected
70	Active
69	Active
68	Active
67	Active
66	Inactive
65	Active
64	Active
63	Active
62	Active
61	Rejected
60	Active
59	Inactive
58	Active
57	Inactive
56	Active
55	Active
54	Active
53	Active
52	Active
51	Active
50	Active
49	Active
48	Active
47	Rejected
46	Active
45	Active
41	Active
40	Rejected
39	Active
38	Active
37	Active
36	Active
35	Active
33	Rejected
32	Active
31	Active
30	Active
29	Active
28	Active
27	Active
26	Active
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Rejected
17	Rejected
16	Active
15	Rejected
14	Active
13	Active
12	Rejected
11	Active
10	Inactive
9	Rejected
8	Inactive
7	Active
6	Rejected
5	Inactive
4	Rejected
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection active July 5, 2021

Approved but for the next version please fix these: 1. You are using vazir-font which is under SIL Open Font License 1.1. It will be good to add LICENSE.md beside that font. 2. You should check in enable() whether the font exist in the destination. then copy. You are doing copy on each enable. This is a very bad approach because on first login and each lock and unlock you are doing that again and again. 3. On disable(), you should check whether you are in lock mode. if it isn't in lock mode, uninstall the font. I don't see the uninstall script triggered anywhere. 4. You don't need to use bash script to copy or delete files. You can do it without spawn command: https://gjs-docs.gnome.org/gio20~2.66p-file/

omid posted a review July 6, 2021

Thanks Javad Jan, Your comments are always so helpful. Please continue doing the awesome work. I have two questions. 1- For license, do you need this inside the extension package for EGO? or inside the repo is enough? 3- How can I check lock mode? (you are right, there is no uninstall script)

JustPerfection posted a review July 6, 2021

Hey, Thanks ;) 1. You should have that on ego packages too. It is a good practice to have README.md, LICENSE.md and CHANGELOG.md files in your project root folder. 2. let isLocked = Main.sessionMode.currentMode === 'unlock-dialog';