Review of "Persian Calendar" version 91

Details Page Preview

Displays Persian (Iranian/Jalali) calendar in the top panel It offers: 1. Displays the Persian/Iranian/Jalali calendar 2. Holiday indicator 3. Day change notifications 4. Converts dates between the Persian, Gregorian, and Hijri (lunar) calendars 5. Event listings: 5.1. Official solar events 5.2. Official lunar events 5.3. Official international events 5.4. Traditional Persian events 5.5. Notable Persian figures Please “rate” the project here and give it a “star” on GitHub. If you encounter any issues or have suggestions, feel free to open an issue there on GitHub!

Extension Homepage
https://github.com/omid/Persian-Calendar-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
JustPerfection posted a review
1. I approved this once since the code is there from the old version. but you should remove the timeouts in disable (line 98 and 103): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
omid posted a review
Sure, thanks. Will do them ASAP. Always learned a lot from you :thumbsup: thanks for your hints.