Review of "CHC-E (Custom Hot Corners - Extended)" version 29.45 (29)

Details Page Preview

Give a function to any corner or edge of your monitors and enhance your keyboard capabilities Mouse pointer pressure, clicks, and scrolls over the monitor corners/edges, or custom keyboard shortcuts can trigger dozens of built-in actions that help you navigate and control your desktop environment or execute your own shell commands. A significant portion of available actions includes visual adjustments (contrast, brightness, opacity) and color filters (red, green, desaturation, lightness, color inversions) and also accessibility features. Do not update extensions from this site, GNOME Shell will do it automatically on the next session start. Please report bugs on GitHub page linked below as Extension Homepage. keywords: keyboard shortcut, switch windows, overview, app grid, command, brightness, contrast, transparent, opacity, color effect, invert lightness, color tint, color blind filter, simulation, desaturate, night lights, dark theme, volume, mute, magnifier, zoom, screen keyboard, reader, large text, force close, kill -9, show desktop, reorder workspace, window thumbnail, preview, looking glass, custom menu, window, workspace, switcher, hide panel

Extension Homepage
https://github.com/G-dH/custom-hot-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
47.0 (42) Active
47.0 (41) Rejected
46.0 (40) Active
46.0 (39) Inactive
45.2 (38) Active
44.2 (37) Active
44.2 (36) Rejected
45.2 (35) Inactive
44.2 (34) Inactive
45.2 (33) Inactive
45.2 (32) Rejected
44.2 (31) Inactive
29.45 (30) Inactive
29.45 (29) Rejected
28 Active
27 Inactive
26 Inactive
25 Inactive
24 Inactive
23 Inactive
22 Inactive
21 Rejected
20 Inactive
19 Inactive
18 Inactive
17 Inactive
16 Inactive
15 Inactive
14 Inactive
13 Inactive
12 Rejected
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. I understand the function doesn't doing too much and it can be approved as is but it will be better to don't call a function in global scope (line 28 extension.js). 2. `getSettings()` should be only used for your extension settings not GNOME settings. for GNOME settings use: ```js const theme = new Gio.Settings({schema_id: 'org.gnome.desktop.interface'}); ``` You are doing that in: - src/prefs/monitorPages.js - src/common/utils.js - src/extension/actions.js 3. You cannot import `Gtk` to the GNOME Shell process (line 14 src/common/utils.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 4. Please also null out `chce` in disable. 5. Don't use `imports.` for 45 extensions: - src/extension/panelMenu.js - src/prefs/optionList.js
GdH posted a review
Thanks! 5. there are no panelMenu.js and optionList.js files and also no imports in any other file
JustPerfection posted a review
Search for those files in the files section.
GdH posted a review
Obsolete files, I was sure I deleted them from the remote repository too... I guess I forgot to commit the change. Thanks for your help! :)