Review "Screenshot Tool" version 57 - GNOME Shell Extensions

Review of "Screenshot Tool" version 57

Details Page Preview

Screenshot Tool

by oal

Conveniently create, copy, store and upload screenshots. Please log out and log in again after updating.

Extension Homepage: https://github.com/OttoAllmendinger/gnome-shell-screenshot/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
76	Active
75	Active
74	Active
73	Active
72	Rejected
71	Rejected
70	Active
69	Active
68	Active
67	Inactive
66	Active
65	Active
64	Active
63	Active
62	Active
61	Active
60	Rejected
59	Inactive
58	Active
57	Rejected
56	Active
55	Active
54	Active
53	Active
52	Active
51	Waiting for author
50	Active
49	Rejected
48	Active
47	Active
46	Active
45	Active
44	Rejected
43	Active
42	Rejected
41	Active
40	Active
39	Rejected
38	Active
37	Active
36	Active
35	Active
34	Active
33	Active
32	Rejected
31	Active
30	Active
29	Active
28	Active
27	Active
26	Active
25	Rejected
24	Inactive
23	Rejected
22	Active
21	Active
20	Active
19	Active
18	Active
17	Active
16	Active
15	Active
14	Active
13	Active
12	Active
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

andyholmes rejected April 8, 2021

You can't throw an Error inside a Promise, unless you plan on wrapping it in a `try..catch`. You should instead call `reject(new Error('message'));`. Please fix this in the function `spawnAsync()` so your extension can be approved.

oal posted a review April 8, 2021

Interesting, I assumed an exception would be translated into a `reject()` call https://stackoverflow.com/a/33912352 I'll fix it to be on the safe side

andyholmes posted a review April 8, 2021

Looks like you are right. I was confusing this situation with nested closures, sorry! I'll approve your latest submission.