Review of "Screenshot Tool" version 60

Details Page Preview

Conveniently create, copy, store and upload screenshots. Please log out and log in again after updating.

Extension Homepage
https://github.com/OttoAllmendinger/gnome-shell-screenshot/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Since you used TypeScript and pushed everything in a single file, so many objects are getting created when the init() function is getting called in extension.js. This is against our rule: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization To fix that, only create objects inside enable(). 2. Some objects are getting created over and over. For example extensionUtils.getSettings() is getting called 4 times. You should create objects like that in enable() and pass it as dependency injection to other objects. If you want to talk to us about this: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions