Review of "Dash to Panel" version 57

Details Page Preview

An icon taskbar for the Gnome Shell. This extension moves the dash into the gnome main panel so that the application launchers and system tray are combined into a single panel, similar to that found in KDE Plasma and Windows 7+. A separate dock is no longer needed for easy access to running and favorited applications. For a more traditional experience, you may also want to use Tweak Tool to enable Windows > Titlebar Buttons > Minimize & Maximize. For the best support, please report any issues on Github. Dash-to-panel is developed and maintained by @jderose9 and @charlesg99.

Extension Homepage
https://github.com/home-sweet-gnome/dash-to-panel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
64 Active
63 Active
62 Active
61 Active
60 Active
59 Active
58 Rejected
57 Rejected
56 Active
55 Active
54 Active
53 Active
52 Active
51 Active
50 Active
49 Active
48 Active
47 Rejected
46 Active
45 Active
44 Active
43 Active
42 Active
41 Active
40 Active
39 Active
38 Active
37 Active
36 Rejected
35 Active
34 Rejected
33 Active
32 Rejected
31 Active
30 Active
29 Active
28 Rejected
27 Rejected
26 Active
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Rejected
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot import `Gtk` to the shell process: - line 29 appIcons.js (not used) - line 22 windowPreview.js (use `St.PolicyType`) - line 30 taskbar.js (use `St.PolicyType`) - line 29 utils.js (use `St.IconTheme`) https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 2. Use `export const` instead of `export var`. 3. No need to init translation (line 60 extension.js, line 2335 prefs.js): https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils 4. Not needed (line 111 extension.js). 5. That's not extension settings (line 132 extension.js). you should get the settings for that with: ```js DESKTOPSETTINGS = new Gio.Settings({schema_id: 'org.gnome.desktop.background'}); ``` 6. Also null out this in disable: ```js DESKTOPSETTINGS = null; ``` 7. Disabling while enable is not a good practice (line 118, 125 extension.js). enable should check if Ubuntu is running first then enable accordingly. 8. You should revert on disable (line 136 extension.js). 9. Should be disconnected on disable (line 140 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals 10. Unused imports: - line 27, 29, 35, 38, 41, 45 appIcons.js - line 22-27 extension.js - line 29 intellihide.js - line 31 overview.js - line 31, 32, 46, 52 panel.js - line 14, 45, 47, 48, 53 panelManager.js - line 24-30 panelStyle.js - line 28 prefs.js - line 21 proximity.js - line 31, 38, 40, 41, 44 taskbar.js - line 18, 21, 23, 25 transparency.js - line 33 utils.js - line 27, 28, 30 windowPreview.js 11. Don't use `imports.`: - line 55 appIcons.js - line 36 extension.js - line 62, 63 panel.js - line 57 panelManager.js - line 34 panelStyle.js - line 36 prefs.js - line 52 taskbar.js - line 38, 39 utils.js - line 35-36 windowPreview.js - line 29 progress.js Use `GLib` instead of `Mainloop`: https://gjs-docs.gnome.org/glib20~2.0/glib.timeout_add https://gjs-docs.gnome.org/glib20~2.0/glib.timeout_add_seconds and remove the timeout with: `GLib.Source.remove(sourceId)`. For `cario` import: ```js import Cairo from 'cairo'; ``` Btw, I don't think you need to import signals for doing this: ```js GObject.registerClass({ Signals: { ``` 12. Unused function (line 38 prefs.js).