Review of "Retro LCD 7-Segment Clock" version 21

Details Page Preview

Vintage digital display with a high-fidelity 7-segment look. 10 color themes, custom colors, ghost segments, CRT scanlines, desktop widget mode, a quick color-switch menu, a date tooltip on hover, and integrated alarms with an on-screen dialog so they're never missed. Draws its digits from SVG path data embedded in the extension's code (no system font installation needed) and plays alarms through GNOME Shell's native sound theme; no bundled audio, font or image files.

Extension Homepage
https://gitlab.com/corral1976/gnome-shell-extension-relojlcd

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

Corral1976 posted a review
Submission Notes for Version 21: Native Audio Implementation: I have completely removed the spawn command for audio playback. The extension now utilizes the native global.display.get_sound_player() and play_from_file APIs as requested. Timeout Management: I have fixed the management of GLib timeouts. The code now explicitly checks for and removes any existing _blinkLoop using GLib.Source.remove() before creating a new instance, preventing process accumulation. Memory Safety: Improved the disable() function to ensure all signals are disconnected via disconnectObject and all active timeouts (audio and visual) are cleared upon deactivation. Assets & Licensing: Proper attribution for the audio (alarm.ogg from Pixabay) and typography (Digital-7 by Style-7) has been added to the README.md in the repository. Code Cleanup: Removed redundant comments and adjusted indentation for better readability and compliance with GNOME Shell coding standards.
JustPerfection rejected
Timeout should be removed before creating a new one (line 108 `extension.js`).