Review of "CHC-E (Custom Hot Corners - Extended)" version 50.0 (49)

Details Page Preview

Give a function to any corner or edge of your monitors and enhance your keyboard capabilities Mouse pointer pressure, clicks, and scrolls over the monitor corners/edges, or custom keyboard shortcuts can trigger dozens of built-in actions that help you navigate and control your desktop environment or execute your own shell commands. A significant portion of available actions includes visual adjustments (contrast, brightness, opacity) and color filters (red, green, desaturation, lightness, color inversions) and also accessibility features. Do not update extensions from this site, GNOME Shell will do it automatically on the next session start. Please report bugs on GitHub page linked below as Extension Homepage. keywords: keyboard shortcut, switch windows, overview, app grid, command, brightness, contrast, transparent, opacity, color effect, invert lightness, color tint, color blind filter, simulation, desaturate, night lights, dark theme, volume, mute, magnifier, zoom, screen keyboard, reader, large text, force close, kill -9, show desktop, reorder workspace, window thumbnail, preview, looking glass, custom menu, window, workspace, switcher, hide panel

Extension Homepage
https://github.com/G-dH/custom-hot-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 3 warning 2

Shexli found 5 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • src/extension/actions.js:749
    win.maximize(Meta.MaximizeFlags.BOTH)
  • src/extension/actions.js:745
    win.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.custom-hot-corners-extended.gschema.xml
    id='org.gnome.shell.extensions.custom-hot-corners-extended.corner' path=''

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.custom-hot-corners-extended.gschema.xml
    id='org.gnome.shell.extensions.custom-hot-corners-extended.corner' path=''
  • schemas/org.gnome.shell.extensions.custom-hot-corners-extended.gschema.xml
    id='org.gnome.shell.extensions.custom-hot-corners-extended.misc' path='/org/gnome/shell/extensions/custom-hot-corners-extended/misc/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:72
    this._mscOptions.connect('changed', (settings, key) => this._updateMscOptions(key))
  • extension.js:279
    corner.connect('changed', chce._updateHotCorners, trigger)

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:358
                this._watch.timeout = GLib.timeout_add(
                    GLib.PRIORITY_DEFAULT,
                    3000,
                    () => {
                        // some extensions can replace the function (Dash to Panel)
                        if (Main.layoutManager._updateHotCorners !== this._updateHotCor

All Versions

Version Status
50.0 (50) Active
50.0 (49) Rejected
49.0 (48) Active
49.0 (47) Inactive
48.1 (46) Active
48.1 (45) Rejected
48.0 (44) Active
48.0 (43) Rejected
47.0 (42) Active
47.0 (41) Rejected
46.0 (40) Active
46.0 (39) Inactive
45.2 (38) Active
44.2 (37) Active
44.2 (36) Rejected
45.2 (35) Inactive
44.2 (34) Inactive
45.2 (33) Inactive
45.2 (32) Rejected
44.2 (31) Inactive
29.45 (30) Inactive
29.45 (29) Rejected
28 Active
27 Inactive
26 Inactive
25 Inactive
24 Inactive
23 Inactive
22 Inactive
21 Rejected
20 Inactive
19 Inactive
18 Inactive
17 Inactive
16 Inactive
15 Inactive
14 Inactive
13 Inactive
12 Rejected
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

GdH auto- rejected
Auto-rejected because of new version 50.0 (50) was uploaded