Review of "Persian Calendar" version 128

Details Page Preview

🗓️ Displays Persian (Iranian/Jalali) calendar in the top panel It offers: 1. Displays the Persian/Iranian/Jalali calendar 2. Holiday indicator 3. Day change notifications 4. Converts dates between the Persian, Gregorian, and Hijri (lunar) calendars 5. Event listings: 5.1. Official solar events 5.2. Official lunar events 5.3. Official international events 5.4. Traditional Persian events 5.5. Notable Persian figures This extension writes to clipboard by user interaction. Please “rate” 💓 the project here and give it a 🌟 on GitHub. If you encounter any issues or have suggestions, feel free to open an issue there on GitHub! Keywords: فارسی / جلالی / تقویم / ایران / ایرانی / گاهشمار / گاه‌شمار / گاهشماری / گاه‌شماری / شمسی / خورشیدی / قمری / میلادی / هجری / Iran / Iranian / Jalali / Persian / Calendar

Extension Homepage
https://github.com/omid/Persian-Calendar-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • Calendar.js:436
    St.Clipboard.get_default()

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils/gettext.js:43
    localeJsonFile.load_contents(null)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. For EGO-X-004 mentioned in Shexli: [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.
omid posted a review
Thanks I did the first one and faced this error: https://github.com/omid/Persian-Calendar-for-Gnome-Shell/pull/179 I did also the last one once, something didn't work which I cannot remember now. I'll try again and report.
JustPerfection posted a review
It's better to use the `gnome-extensions pack` command to create the zip package: [Example](https://gitlab.gnome.org/jrahmatzadeh/just-perfection/-/blob/d2e7da71ba3ceec6dc9908108a13be972135ead1/scripts/build.sh#L19-25)