Review of "Dash to Panel" version 74

Details Page Preview

An icon taskbar for the Gnome Shell. This extension moves the dash into the gnome main panel so that the application launchers and system tray are combined into a single panel, similar to that found in KDE Plasma and Windows 7+. A separate dock is no longer needed for easy access to running and favorited applications. For a more traditional experience, you may also want to use Tweak Tool to enable Windows > Titlebar Buttons > Minimize & Maximize. For the best support, please report any issues on Github. Dash-to-panel is developed and maintained by @jderose9 and @charlesg99.

Extension Homepage
https://github.com/home-sweet-gnome/dash-to-panel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • desktopIconsIntegration.js:74
    Extension.lookupByURL(import.meta.url)
  • prefs.js:158
    ExtensionPreferences.lookupByURL(import.meta.url)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • panelSettings.js:82
    console.log('Error parsing positions: ' + e.message)
  • panelSettings.js:92
    console.log('Error serializing setting: ' + e.message)
  • panelSettings.js:137
    console.log('Not setting invalid panel size: ' + value)
  • panelSettings.js:156
    console.log('Not setting invalid panel length: ' + value, new Error().stack)
  • panelSettings.js:182
    console.log('Not setting invalid panel position: ' + value)
  • panelSettings.js:196
    console.log('Not setting invalid panel anchor: ' + value)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['46', '47', '48', '49', '50', '51']

All Versions

Previous Reviews on this Version

JustPerfection active
charlesg99 posted a review
Thank you and glad to have you back!
JustPerfection posted a review
Thanks!