Just noticed I posted the change log notes (addressing the previous issues) to the old review. Re-posting here for convenience: - [x] **1 DONE**. Good pickup and call here - was a bit of a mess. Including a very interesting hard-coding of the `version` var (was written back before Gnome 40). In any case, the first commit here was fixing that and removing old/deprecated code that was for gnome 3.xx. - [x] **2 DONE**. `sessionModes` removed from metadata.json (not needed in PaperWM). Also improved the `safeCall` logging to only log if called method exists in module. - [x] **3 DONE**. I'm not sure of the original reason for setting `Extension` like it was doing. Replaced with a much simpler `var Extension = imports.misc.extensionUtils.getCurrentExtension();`. - [x] **4 DONE**. Removed `convenience.js` as it duplicates current Gnome ExtensionUtils and refactored modules that used it . - [x] **5 DONE**. Removed unneeded check. - [x] **6 DONE.**. did full review of all `mainloop.timeout_add` instances - most were actually (intended) as once off calls (e.g. destroy after first handler execution) - changed these to destroy after handler function execution. - [x] **7 DONE**. Went through and cleaned up `imports.xxx` references (and moving them to top where possible). - [x] **8 DONE**. We were actually delegating the animation through `utils.tweener`... which was actually using `Widget.ease(...)`. This was basically because it was easier to do this when we switched to `ease`. However, this is quite confusing for users/reviews. I've taken the opportunity now to rename `Tweener.addTween(...)` to `Ease.addEase(...)` etc. - [x] **9 DONE** (finally!). This was a very good point in the review. Polyfilling in functions on global gnome objects isn't the best approach here. I've now replaced the polyfills with backwards-compatible utility functions which is a cleaner/safer/better approach and should make this much easier to maintain going forward. - [x] **10 DONE**. Replaced the use of `print(...)` across PaperWM. - [x] **11 DONE**. Moved global scope creation of instances to `enable` in `Kludges.sj`, `liveAltTab.js`, `prefs.js`, `tiling.js`. Also cleaned up and removed unneeded imports dependencies and improved formatting. - [x] **12 DONE**. Hmm - we don't see an issue with importing Gtk and using accelerator_parse etc. But we have cleaned up and removed references to Gtk where not needed. - [x] **13 DONE**. We've removed the hot corner overriding/disabling from PaperWM. This was largely superfluous since hot corner works fine in PaperWM, and if users want to disable it they can do so via the usual gnome setting. Having two functions that disable hot corner (one in gnome and one in PaperWM) seems superfluous. - [x] **14 DONE**. Removed unneeded import in `minimap.js`. - [x] **15 DONE**. `destroy` should not call `dismissDispatcher` since `dismissDispatcher` calls `destroy`... leading to an infinite loop (recursion). - [x] **16 DONE**. All `log(...)` lines reviewed and removed superfluous logging; - [x] **17 DONE**. Lower-cased PaperWM schema id values and recompiled schema. - [x] **18 DONE**. Refactored to NOT call `setSchemas()` on Settings `init` (is now called on `enable`). - [x] **19 DONE**. nulled out vars (that we missed). Good pickup! - [x] **20 DONE**. Now untracking on `destroy()`. - [x] **21 DONE**. Refactored StackOverlay class - added proper destroy method and now removePreview on destroy. - [x] **22 DONE**. Timeouts are now oneshot (remove/destroy timeout after function callback). - [x] **23 DONE**. Added missing semicolons and other cleanup in `virtTiling.js`. - [x] **24 DONE**. Now using `add_style_class_name` and `remove_style_class_name` to not run over other extension styles. - [x] **25 DONE**. Removed Gdk import from Tiling.js. - [x] **26 DONE**. Removed module self reference from `keybindings.js` and `tiling.js`. - [x] **27 DONE**. Replaced `Gdk.Keymap` (which isn't available in Gnome 40+) with `Clutter.get_default_backend().get_default_seat().get_keymap()` and hence removed `Gdk` import from `keybindings.js`. Haven't been able to remove `Gtk` since we need `accelerator_parse` from `Gtk`.

Ah, so, in further testing it turns out that PaperWM definitely does need session mode `unlock-dialog`: **Justification:** PaperWM requires session mode `unlock-dialog` to maintain multi-monitor tiling layouts when locking/unlocking Gnome. Without this, tiled windows can move to different monitors on gnome unlock, which severely impacts/destroys user workflows and window placements. JustPerfection, is there somewhere I add a note for this justification? (in the extension somewhere?). I'm planning on submitting another version with this change to `metadata.json` - should I just submit this now, or would you prefer to finish a review of this version first?

Auto-rejected because of new version 3 was uploaded