Apologies, We caught a small regression in version 4 which was promptly fixed. Have update to the corrected version. > Evening Javad, > > Big thanks for the guidance given thus far Javad. Please see our latest submission. I believe (hope) I've caught everything, so hopefully we're getting closer. > > Regards, > > Jay. > > P.S. hope GUADEC is going well!

Yeah, we had a great BoF for extensions this year :p Approved! The code quality is improved a lot since version 1. Happy to see that. For future updates please consider these recommendations: 1. Instead of `Extension.dir.get_path()` you can use `Extension.path` which is a much nicer alternative for global scope. 2. Since you are calling `signals.destroy()` it would pass but please also null out `signals` in all disable functions. 3. It's better to don't use `gsettings.run_dispose()`. as mentioned in the doc: > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose Nulling out the `gsettings` would be enough since `gsettings` is owned by your extension. Thanks!

Many thanks Javad! > The code quality is improved a lot since version 1. Happy to see that. 100% (or probably more!). So glad started the journey here since it has (drastically) improved the PaperWM code (plus, I learned a ton more about extensions, gjs, and what makes good, clean code extension code). > For future updates please consider these recommendations: Yep, I've already implemented these changes and will submit another version today or tomorrow to clean these up. P.S. I'll have a look as well, but please let me know if there's anything I can do to get involved and help with extensions/ego. Kind regards, Jay.

Great! The best way to get involved is to join us on GNOME Matrix channel. That's where you find extension developers, reviewers and GNOME Shell developers. Btw, GNOME Shell 45 will break all extensions :p getting connected with us on GNOME Matrix channel can definitely help. - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

Thanks Javad. > Btw, GNOME Shell 45 will break all extensions :p Oh, dear - yes I was watching some GUADEC presentations, one on GJS and changes coming in 45... suspected it would break quite a few extensions. Well, onwards and upwards (price of progress I reckon). P.S. have joined the matrix gnome channel - will try get more involved there. Cheers.